On 01/19/2011 03:38 AM, Paul Eggert wrote: > * unexmacosx.c includes the Gnulib <unistd.h>.
That's always a bug to include any gnulib-provided header prior to <config.h>. > > * And when Gnulib <getopt.h> declares a 'struct option', this clashes > with the 'struct option' declared in the system getopt.h. And this is a known symptom of violating the above constraint. > > PS. This all seems to be a case where we should be using Gnulib's > identifier replacement mechanism, but I don't understand it that > well and if memory serves it doesn't work with struct tags anyway. We've managed to modernize other headers to properly declare replacement structs exactly once; it is merely a matter of someone having enough time to modernize the gnulib getopt module to use modern constructs rather than abusing config.h to define an rpl_ prefix. -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
