On 01/20/2011 09:08 AM, Benjamin Lindner wrote:
>> git IS used by the bootstrap script except for the one case where you
>> specifically ask that it not be used.  So, the best thing might be to
>> enhance the bootstrap pre-requisite checks to see if --gnulib-srcdir is
>> in effect and use that as a reason to skip the git prereq check.
> 
> That sounds simple & reasonable. Would patches be considered?

Absolutely.

One idea would be:

--gnulib-srcdir overrides environment, but defaults to $GNULIB_SRCDIR

bootstrap                            require git, creates fresh clone
bootstrap --gnulib-srcdir            require git, clones using srcdir as
reference
bootstrap --no-git                   error (unless GNULIB_SRCDIR is in
environment)
bootstrap --gnulib-srcdir --no-git   avoid git, use srcdir directly

where the new --no-git option is what makes it explicit that you intend
to use an existing directory as-is rather than update a submodule in
your local tree.

-- 
Eric Blake   [email protected]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to