Paul Eggert wrote: > Here's a simple patch to remove crypto/md5's dependence on > stdint. It complicates the code in md5.h a bit
35 lines of code to define a type md5_uint32, that is only used in md5.h? That's a step backwards to where we were before gnulib. The benefit of gnulib is that we can program according to ISO C 99 and POSIX, and our code is not littered with auxiliary code for various deficient platforms. > but the result is closer to what's already in glibc. The code in glibc was written to be reusable before gnulib came along. When we simplified the code in gnulib on 2005-10-17, we also asked to sync glibc, but Ulrich did not want this: <http://sourceware.org/bugzilla/show_bug.cgi?id=1439>. IMO this is not sufficient reason to change gnulib back to where we were before. > This will make it quite a bit easier for Emacs to use crypto/md5. Since this is only for Emacs, I'd prefer if these modifications were stored in the Emacs repository only, as files gnulib-local/lib/md5.h.diff gnulib-local/lib/md5.c.diff where they can be automatically be taken into account by gnulib-tool's --local-dir option. Bruno -- In memoriam Khosrow Golsorkhi <http://en.wikipedia.org/wiki/Khosrow_Golsorkhi>
