On 10/07/11 10:56, James Youngman wrote: > I just went to use some function attributes in findutils and noticed > that information about which versions of GCC support various > attributes is spread throughout gnulib. While a number of headers > define convenience macros (usually starting _GL_ATTRIBUTE_) there are > a couple of naming inconsistencies (two names used for the same > attribute, typically). > > I propose to move all of these definitions into a separate module, > except for any definitions that need to stay as they are in order to > stay in sync with glibc: > > $ for h in $(grep -l 'define.*_GL_ATTRIBUTE' lib/*.[hc]) ; do grep -q > 'This file is part of the GNU C Library' $h || echo $h; done > lib/di-set.h > lib/hash.h > lib/ignore-value.h > lib/ino-map.h > lib/openat.h > lib/safe-alloc.h > lib/sigpipe-die.h > lib/stdio.in.h > lib/stdlib.in.h > lib/string.in.h > lib/vasnprintf.h > lib/version-etc.h > lib/xalloc.h > lib/xmemdup0.h > lib/xprintf.h > lib/xstrtol.h > lib/xvasprintf.h > > Since this involves touching a number of files, I thought it would be > useful to get some feedback on the idea in advance rather than just > send a patch for review.
I like it. The fact that macros with the same funcionality but different names have already been defined, suggests this is worthwhile. It would also result is less duplication of the GNUC_PREREQ stuff. thanks, Pádraig.
