On 08/04/2011 07:14 PM, Bruno Haible wrote:

/* Check that PATH_MAX is a constant if it is defined.  */
#ifdef PATH_MAX
int a = PATH_MAX;

Shouldn't this be:

static int a[PATH_MAX];

so that we really are testing that it is a constant? And do we also want to enforce that it is usable as a preprocessor number, as in something like:

#ifdef PATH_MAX
# if !PATH_MAX
#  error
# endif
#endif

--
Eric Blake   [email protected]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Reply via email to