On 10/03/2011 05:23 PM, Bruno Haible wrote:
On MSVC 9, strsignal.c gets many compilation errors,
because glthread/lock.h includes<windows.h>, which includes<winsock.h>,
and<unistd.h> includes<winsock2.h>. The two socket headers collide.
Also, it can get a compilation error because it uses<unistd.h> without
depending on the 'unistd' module.
Shouldn't the fix for this to be adding a module dependency in
modules/strsignal, rather than...
* lib/strsignal.c: Include<string.h> first. Don't include<unistd.h>
if HAVE_UNISTD_H is false.
reverting to the use of HAVE_UNISTD_H in a .c file?
--
Eric Blake [email protected] +1-801-349-2682
Libvirt virtualization library http://libvirt.org
