On 08/18/2012 10:04 PM, Ben Pfaff wrote: > I see that some of your patches remove "inline" from some "static > inline" functions in header files, but I don't see anything > added, such as __attribute__((unused)), that would suppress an > "unused static function" warning. (Perhaps I just missed it.)
Thanks for bringing that up. I didn't observe those warnings even when configuring with --enable-gcc-warnings. I just now looked into matter and it turns out that the warnings are suppressed by the "#pragma GCC system_header" at the start of all the files that contain the patches you're referring to. So we should be OK. For headers that are not system headers, I plan to use _GL_INLINE, which addresses the problem in a different way.
