the check as it stands works only for gcc 4.6 and later because of #pragma GCC diagnostic push|pop
--- On Mon, 12/17/12, Pádraig Brady <[email protected]> wrote: On 12/17/2012 11:50 AM, Z. Majeed wrote: > Building latest [coreutils] git source (=> gnulib d245e6d)... > ... I had to configure --disable-gcc-warnings to avoid the following errors > because gcc 4.5.3 is the latest on cygwin and not covered by the ignore > warnings pragma in extern-inline.m4 for gcc 4.6 and higher: > CC dtotimespec.o > In file included from dtotimespec.c:25:0: > timespec.h:58:1: error: no previous declaration for 'timespec_cmp' > [-Werror=missing-declarations] > timespec_cmp (struct timespec a, struct timespec b) Should the check in extern-inline.m4 be expanded to all __GNUC_? 39cedf6f said the issue was only with gcc 4.8, but GCC 4.5.3 (on cygwin at least), seems to have the issue too. thanks, Pádraig.
