On Mon, Oct 21, 2013 at 10:51:38PM -0700, Ben Pfaff wrote: > On Mon, Oct 21, 2013 at 08:08:26PM +0200, Sylvain wrote: > > Hi, > > > > On Sun, Oct 20, 2013 at 01:48:19PM -0700, Ben Pfaff wrote: > > > Sylvain <b...@beuc.net> writes: > > > > > > > It's been a while (1 year 1/2) since > > > > http://lists.debian.org/debian-bsd/2012/05/msg00032.html and I still > > > > need to manually patch gnulib before releasing. > > > > > > > > If I assume the relocatable-prog module is not maintained, that I'm > > > > probably the only person on earth to use it, and that I should just > > > > drop it from my package, am I wrong? ;) > > > > > > No, we use relocatable-prog in GNU PSPP as well. I build with it > > > all the time. But I don't use Debian/kFreeBSD or Debian/Hurd, so > > > I don't see this problem. > > > > I don't use them either, but the Debian autobuilder does :) > > In the case of pspp, I see that it compiles fine on these > > platforms, e,g.: > > https://buildd.debian.org/status/fetch.php?pkg=pspp&arch=kfreebsd-amd64&ver=0.7.9%2bgit20120620-1.2&stamp=1369659905 > > > > AFAIU you'll hit the bug as soon as you have more than 1 program in a > > bin_PROGRAMS statement. Mine is: > > bin_PROGRAMS = freedink freedinkedit > > > > In this case automake makes 1 call to 'install' with multiple > > arguments, but 'install-reloc' only support one. Bruno's patch adds > > support for multiple arguments. It's as simple as that. > > > > > > > I do read this list, and I am a maintainer of relocatable-prog, > > > but somehow I missed the discussion. Maybe I thought that Bruno > > > was going to take care of it, since he suggested the patch. > > > > > > Are you still happy with install-reloc with Bruno's patch? If > > > so, then I will commit it to gnulib. > > > > The patch is manually applied for each FreeDink release and compiles > > on all Debian architectures (as well as other distros and OSes). > > > > When discussing with Bruno at GHM 2012, he told me he absolutely > > wanted to write a test case first. But after this much time I wonder > > why a non-test-cased bug should prevail over an non-test-cased fix ;) > > > > So as far as I'm concerned, I'd be happy to see this fix committed :) > > That sounds reasonable to me. > > Here is what I plan to commit. Does anyone see anything I should change > beforehand? It has been a long time since I did much work on gnulib > (mainly because "it just works" for me these days), so I want to make > sure I'm not overlooking something. > > All of the substantive change in the patch is by Bruno, hence I am > making him the author of the commit (I will be the committer, if I push > it).
After waiting about 72 hours, I received no comments, whether positive, negative, or neutral, so I applied this to master. Thanks, Ben.