On 11/07/2013 11:14 AM, Benjamin Cama wrote: > The test was inverted. > > Signed-off-by: Benjamin Cama <[email protected]> > --- > gnulib-tool | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gnulib-tool b/gnulib-tool > index 669931c..55fbee3 100755 > --- a/gnulib-tool > +++ b/gnulib-tool > @@ -2954,7 +2954,7 @@ ba > fi > done > # Add the dummy module, to make sure the library will be non-empty. > - if test -z "$have_lib_SOURCES"; then > + if test -n "$have_lib_SOURCES"; then > if func_acceptable "dummy"; then > func_append modules " dummy"
Huh? The existing code seems correct - if there were no other lib_SOURCES (the variable is empty), then we need to add dummy so that we have at least one lib source. Your patch would change it so that if there are lib_SOURCES, then we also include dummy. I think I need a bit more context why your patch would be correct. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
