On Sun, Oct 18, 2015 at 2:36 PM, Pádraig Brady <[email protected]> wrote: > On 18/10/15 22:33, Pádraig Brady wrote: >> On 18/10/15 05:04, Jim Meyering wrote: >>> I've just pushed the following three patches: >> >> Nice. Note this improvement triggered new >> syntax check failures on coreutils >> >> $ make sc_tight_scope >> prog_fprintf >> rm >> defaultcon >> restorecon >> ... >> >> That's because the gnulib rule was working on an >> invalid blank regular expression extracted from SOURCES, >> thus effectively being ignored, as it was matching all >> extern functions found with nm. with your added ^_?$ >> around the expression, this no longer happened, thus >> triggering the above valid issues. >> >> I've sent a patch to coreutils to fix those, >> and the attached gnulib patch is not strictly required >> after your improvements, though it does remove some >> extraneous unlikely to match expressions. > > correct patch attached this time
Thanks. Filtering out empty lines as well as anything starting with "#" are fine changes.
