On Mon, Aug 29, 2016 at 12:05 PM, Paul Eggert <egg...@cs.ucla.edu> wrote: > Jim Meyering wrote: > >> Good catch. >> Thanks. > > > In trying it out on GNU Emacs with GCC 6.2 I ran into another problem: it > complains at compile-time if __builtin_add_overflow's 3rd arg is null. In > some GCC versions this is supposed to discard the value, but I guess that > capability is superseded by __builtin_add_overflow_p. So I installed the > attached additional patch, which avoids the need for a null argument so we > don't have to worry about GCC version details there.
Thanks for making that work with 6.2 I noticed that you did not update the use in lib/xalloc-oversized.h, and that too fails to compile with gcc-6.2.
