Hi Darshit,

Looks quite complete now. Other than what Paul mentioned:

* You appear to be using tabs of widths 4. Therefore use "expand -t 4" to
  untabify the files you modified.

* The documentation:
  - Could you add an URL to the documentation of this function? (glibc
    manual or, if not available, manpage from the LTP)
  - The function is not present on any other system, I checked. Therefore the
    text should read:

    This function is missing on all non-glibc platforms:
    glibc 2.25, Mac OS X 10.5, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 
3.1.8, AIX 5.1, HP-UX 11, IRIX 6.5, OSF/1 5.1, Solaris 11 2011-11, Cygwin, 
mingw, MSVC 14, Interix 3.5, BeOS.

* In the tests, you could add a check for the declaration of the function.
  Look in test-strchrnul.c how we do it.

> However, it does not work and fails the test. It seems to me that I have 
> not managed to correctly coerce stdlib.h into defining a prototype for 
> reallocarray(). Where did I go wrong / what did I miss?

I don't see a problem. IMO
  $ ./gnulib-tool --test reallocarray
should work fine. Let's debug it when you've resubmitted once more.


Reply via email to