Hi Ken, > > The '! defined __CYGWIN__' part is redundant, > > because _WIN32 is never defined on Cygwin. > > No. _WIN32 is not defined _by_default_ on Cygwin. But users can use > "gcc -D_WIN32", when they want to access native Windows APIs (for > whatever reason).
In fact, you can see from [1] that up until two weeks ago, the normal way to build libxml2 on Cygwin was with -D_WIN32. Otherwise, why would people have written '#if defined(_WIN32) && defined(__CYGWIN__)' ? Bruno [1] https://gitlab.gnome.org/GNOME/libxml2/commit/c65c9e8ee07e2dab0647392c2bd1795a5bc99829
