There was an issue with syntax-check on FreeBSD reported a few years

The patch series attempts to resolve the issue on gnulib side. With
related changes on libvirt side I can run make syntax-check on macOS.

* modules/maintainer-makefile (configure.ac): Look for the best
  available ggrep or grep with AC_PROG_GREP.
* top/maint.mk: Split long argument lists with xargs. Replace grep
  invocations with $(GREP).

v2: http://lists.gnu.org/archive/html/bug-gnulib/2018-12/msg00026.html

Changes since v2:
- removed /dev/null argument for grep invocations with "-l" flag
- reformatted all affected multi-line commands to be more consistent
  with the style of the code around with regards to &&, || and |
- removed dependency on mkdir in sc_prohibit_always-defined_macros
- rewrote sc_po_check to avoid running perl with $(generated_files)
  multiple times
- rewrote sc_cross_check_PATH_usage_in_tests to simplify indentation

v1: http://lists.gnu.org/archive/html/bug-gnulib/2018-11/msg00069.html

Changes since v1:
- removed VC_ARG_MAX
- removed "-n" flag in xargs invocations
- added /dev/null as an extra file for uniform grep output regardless of
  number of files. The file isn't added if grep invocation has "-L" flag
- added dependency on AC_PROG_GREP to modules/maintainer-makefile

Best regards,

Roman Bolshakov (2):
  maint.mk: Split long argument lists
  maint.mk: Replace grep with $(GREP)

 modules/maintainer-makefile |   1 +
 top/maint.mk                | 207 +++++++++++++++++++++---------------
 2 files changed, 123 insertions(+), 85 deletions(-)

2.17.2 (Apple Git-113)

Reply via email to