Now that we have the right tool for determining the recursive link dependencies
of modules, it becomes apparent that some of the 'Link' fields are incorrect:

- acl, faccessat, fdutimensat, propername, unicodeio, utimecmp, utimensat,
  xstriconv, xstriconveh lack
  '$(LTLIBINTL) when linking with libtool, $(LIBINTL) otherwise'.
- iconv_open-utf lacks
  '$(LTLIBICONV) when linking with libtool, $(LIBICONV) otherwise'.
- crypto/md5, crypto/sha1, crypto/sha256, crypto/sha512 lack '$(LIB_CRYPTO)'.
- qacl lacks '$(LIB_ACL)'.

This patch fixes it.


2019-01-04  Bruno Haible  <br...@clisp.org>

        Remove incorrect 'Link' sections.
        * modules/acl (Link): Remove section. Use combined 'Link' sections from
        the dependencies instead.
        * modules/crypto/md5 (Link): Likewise.
        * modules/crypto/sha1 (Link): Likewise.
        * modules/crypto/sha256 (Link): Likewise.
        * modules/crypto/sha512 (Link): Likewise.
        * modules/faccessat (Link): Likewise.
        * modules/fdutimensat (Link): Likewise.
        * modules/iconv_open-utf (Link): Likewise.
        * modules/propername (Link): Likewise.
        * modules/qacl (Link): Likewise.
        * modules/unicodeio (Link): Likewise.
        * modules/utimecmp (Link): Likewise.
        * modules/utimensat (Link): Likewise.
        * modules/xstriconv (Link): Likewise.
        * modules/xstriconveh (Link): Likewise.

diff --git a/modules/acl b/modules/acl
index b42ed08..83422bc 100644
--- a/modules/acl
+++ b/modules/acl
@@ -21,9 +21,6 @@ lib_SOURCES += copy-acl.c set-acl.c
 Include:
 "acl.h"
 
-Link:
-$(LIB_ACL)
-
 License:
 GPL
 
diff --git a/modules/crypto/md5 b/modules/crypto/md5
index 4c0e165..afcdbc3 100644
--- a/modules/crypto/md5
+++ b/modules/crypto/md5
@@ -15,8 +15,6 @@ Makefile.am:
 Include:
 "md5.h"
 
-Link:
-
 License:
 LGPLv2+
 
diff --git a/modules/crypto/sha1 b/modules/crypto/sha1
index 27ca394..86ae4d8 100644
--- a/modules/crypto/sha1
+++ b/modules/crypto/sha1
@@ -15,8 +15,6 @@ Makefile.am:
 Include:
 "sha1.h"
 
-Link:
-
 License:
 LGPLv2+
 
diff --git a/modules/crypto/sha256 b/modules/crypto/sha256
index 6a75280..0e2b4f0 100644
--- a/modules/crypto/sha256
+++ b/modules/crypto/sha256
@@ -15,8 +15,6 @@ Makefile.am:
 Include:
 "sha256.h"
 
-Link:
-
 License:
 LGPLv2+
 
diff --git a/modules/crypto/sha512 b/modules/crypto/sha512
index da45e81..c4827c6 100644
--- a/modules/crypto/sha512
+++ b/modules/crypto/sha512
@@ -15,8 +15,6 @@ Makefile.am:
 Include:
 "sha512.h"
 
-Link:
-
 License:
 LGPLv2+
 
diff --git a/modules/faccessat b/modules/faccessat
index d13d167..170aa7b 100644
--- a/modules/faccessat
+++ b/modules/faccessat
@@ -35,9 +35,6 @@ Include:
 <fcntl.h>
 <unistd.h>
 
-Link:
-$(LIB_EACCESS)
-
 License:
 GPL
 
diff --git a/modules/fdutimensat b/modules/fdutimensat
index 093b1a6..21d656f 100644
--- a/modules/fdutimensat
+++ b/modules/fdutimensat
@@ -19,9 +19,6 @@ Include:
 <fcntl.h>
 "utimens.h"
 
-Link:
-$(LIB_CLOCK_GETTIME)
-
 License:
 GPL
 
diff --git a/modules/iconv_open-utf b/modules/iconv_open-utf
index 40da9a1..bcd7b8b 100644
--- a/modules/iconv_open-utf
+++ b/modules/iconv_open-utf
@@ -14,8 +14,6 @@ Makefile.am:
 
 Include:
 
-Link:
-
 License:
 LGPL
 
diff --git a/modules/propername b/modules/propername
index 0cc93bf..c924184 100644
--- a/modules/propername
+++ b/modules/propername
@@ -35,9 +35,6 @@ lib_SOURCES += propername.h propername.c
 Include:
 "propername.h"
 
-Link:
-$(LTLIBICONV) when linking with libtool, $(LIBICONV) otherwise
-
 License:
 GPL
 
diff --git a/modules/qacl b/modules/qacl
index 20c49ac..45753c7 100644
--- a/modules/qacl
+++ b/modules/qacl
@@ -15,8 +15,6 @@ Makefile.am:
 
 Include:
 
-Link:
-
 License:
 GPL
 
diff --git a/modules/unicodeio b/modules/unicodeio
index 51721db..8164ac4 100644
--- a/modules/unicodeio
+++ b/modules/unicodeio
@@ -24,9 +24,6 @@ lib_SOURCES += unicodeio.h unicodeio.c
 Include:
 "unicodeio.h"
 
-Link:
-$(LTLIBICONV) when linking with libtool, $(LIBICONV) otherwise
-
 License:
 GPL
 
diff --git a/modules/utimecmp b/modules/utimecmp
index 8a3303c..dffe861 100644
--- a/modules/utimecmp
+++ b/modules/utimecmp
@@ -27,9 +27,6 @@ lib_SOURCES += utimecmp.c
 Include:
 "utimecmp.h"
 
-Link:
-$(LIB_CLOCK_GETTIME)
-
 License:
 GPL
 
diff --git a/modules/utimensat b/modules/utimensat
index 6e0524c..27e4679 100644
--- a/modules/utimensat
+++ b/modules/utimensat
@@ -33,9 +33,6 @@ Makefile.am:
 Include:
 <sys/stat.h>
 
-Link:
-$(LIB_CLOCK_GETTIME)
-
 License:
 GPL
 
diff --git a/modules/xstriconv b/modules/xstriconv
index ce95f86..a052aea 100644
--- a/modules/xstriconv
+++ b/modules/xstriconv
@@ -18,9 +18,6 @@ lib_SOURCES += xstriconv.h xstriconv.c
 Include:
 "xstriconv.h"
 
-Link:
-$(LTLIBICONV) when linking with libtool, $(LIBICONV) otherwise
-
 License:
 GPL
 
diff --git a/modules/xstriconveh b/modules/xstriconveh
index fabeb44..4327156 100644
--- a/modules/xstriconveh
+++ b/modules/xstriconveh
@@ -18,9 +18,6 @@ lib_SOURCES += xstriconveh.c
 Include:
 "xstriconveh.h"
 
-Link:
-$(LTLIBICONV) when linking with libtool, $(LIBICONV) otherwise
-
 License:
 GPL
 


Reply via email to