Hi Bruno! > Le 13 janv. 2019 à 13:31, Bruno Haible <br...@clisp.org> a écrit : > > Hi Akim, > >> I tried to use the backup-rename module, and it failed to compile for lack >> of "opendirat.h". So I think we need this patch. >> >> Cheers! >> >> >> commit ffd5d5bb4b282d4e7a1f83d5a60ade30bac5a6f1 >> Author: Akim Demaille <akim.demai...@gmail.com> >> Date: Sun Jan 13 11:16:20 2019 +0100 >> >> backup-rename: update dependencies >> >> * modules/backup-rename (Depends-on): It now depends on opendirat >> instead of opendir. > > Good finding. The issue originated in the commit from 2018-10-24 > 1b01fe40918401a965651499b0ba37ff53be86a9 . > > When you look at this commit, you'll see two more modifications of > modules/backupfile that need to be replicated in modules/backup-rename.
I think that it's more than this. It seems quite difficult to track these dependencies. Can nothing be automated there? commit ec77a711543fcaf17676ad4b63a2ce850f124a86 Author: Akim Demaille <akim.demai...@gmail.com> Date: Sun Jan 13 11:16:20 2019 +0100 backup: update dependencies * modules/backup-rename (Depends-on): It now depends on opendirat instead of opendir. It also uses stdbool, and xalloc-oversized. But no longer dirfd. * modules/backupfile (Depends-on): Add xalloc-oversized. diff --git a/ChangeLog b/ChangeLog index 81f83349e..d49779499 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2019-01-13 Akim Demaille <a...@lrde.epita.fr> + + backup: update dependencies + * modules/backup-rename (Depends-on): It now depends on opendirat + instead of opendir. It also uses stdbool, and xalloc-oversized. + But no longer dirfd. + * modules/backupfile (Depends-on): Add xalloc-oversized. + 2019-01-10 Bruno Haible <br...@clisp.org> verify: Enable _GL_HAVE_STATIC_ASSERT for recent G++ versions. diff --git a/modules/backup-rename b/modules/backup-rename index 7e551af52..3cb37ddcf 100644 --- a/modules/backup-rename +++ b/modules/backup-rename @@ -13,14 +13,15 @@ argmatch closedir d-ino dirent-safer -dirfd dirname-lgpl fcntl memcmp -opendir -renameatu +opendirat readdir +renameatu stdbool +stdint +xalloc-oversized configure.ac: gl_BACKUPFILE diff --git a/modules/backupfile b/modules/backupfile index 5dcf6c708..429faa6bf 100644 --- a/modules/backupfile +++ b/modules/backupfile @@ -17,11 +17,12 @@ dirname-lgpl fcntl memcmp opendirat -renameatu readdir +renameatu stdbool stdint xalloc +xalloc-oversized configure.ac: gl_BACKUPFILE