On Wed, Jan 23, 2019 at 10:48:23PM +0100, Akim Demaille wrote: > Hi Ben, > > This is what I get currently: > > cd bison && /bin/sh build-aux/missing automake-1.16 --gnu Makefile > lib/gnulib.mk:1677: warning: .PHONY was already defined in condition TRUE, > which includes condition RELOCATABLE_VIA_WRAPPER ... > Makefile.am:71: 'lib/local.mk' included from here > lib/local.mk:16: 'lib/gnulib.mk' included from here > doc/local.mk:168: ... '.PHONY' previously defined here > Makefile.am:68: 'doc/local.mk' included from here > > this is because relocatable-prog's Makefile snippet uses .PHONY in a > conditional. AFAICT the only difference is that when not enabled, "make > uninstall-relocwrapper" will do nothing instead of being an error. The > rigorous alternative would be to define a variable in the conditional and use > it in .PHONY. Would you prefer that?
I think your solution is fine. Thank you.