Hi Paul, thank you very much.
If I understand correctly, the patch seems to cover compilers that declare "__has_attribute", which should cover GCC and Clang. Does it make sense to support MSC's "__declspec" as well? As for the future-proof C2X approach: In the GCC 10 Changes (https://gcc.gnu.org/gcc-10/changes.html), the C2X standard attributes are written without double underscores. In the attached patch, they are. What is correct? Marc Am So., 3. Mai 2020 um 08:21 Uhr schrieb Paul Eggert <egg...@cs.ucla.edu>: > > Thanks for catching those glitches. I suppose you're right, the new > _GL_ATTRIBUTE_* macros should be in gnulib-common.m4 even though that will now > grow by a bit (meaning config.h will grow quite a bit). Attached is a revised > draft patch to Gnulib, which (unlike the previous one) I have tested a bit. It > doesn't attempt to revamp all of Gnulib to use the new macros, but does enough > of them to give a flavor for the conversion.