> On 4 Feb 2023, at 18:46, Paul Eggert <egg...@cs.ucla.edu> wrote: > > I manually inspected fts.c to look for violations of the C standard that > might draw GCC's attention, and installed the attached patches into Gnulib. > As you can see, they don't fix the technical violations of the C standard. > However, I hope they keep GCC happy. Please give them a try with "GCC > 13.1".<0001-fts-pacify-GCC-13-Wuse-after-free.patch><0002-fts-pacify-GCC-12-Wstrict-aliasing.patch>
For what it's worth, with GCC 13.0.1 20230129, I get no warnings with --enable-gcc-warnings, and the test suite passes. Ditto =expensive. But I don't get any with the previous commits either :) As for the patches, I'd consider using #pragma GCC ... to suppress -Wuse-after-free for the "problematic" lines instead. It'd avoid the risk of either optimisations or sanitisers respectively causing us pain in future.
signature.asc
Description: Message signed with OpenPGP
