On 2024-02-15 13:56, Bruno Haible wrote:
The effect of your patch is merely that Emacs users on Solaris or NetBSD, in a French locale (or one of many other locales) will get an AM/PM string attached to their date+time display. Something which is a no-go in such locales, because it goes against the cultural conventions.
Yes it's an annoyance, but only on uncommon platforms and those platforms' users must be used to other utilities misbehaving in the same annoying way.
Thanks for improving nstrftime so that it doesn't need Gnulib's locking code. However that brings us to the next issue, which is that Emacs has its own hacky way of doing locales. I'm a bit rusty on that and so will have to think about its interaction with Gnulib nstrftime on Solaris and NetBSD. In the meantime I installed the attached further patch to bleeding-edge Emacs to work around this low-priority issue.
(I misspelled "finesse" in the commit message, sorry.)
From 37bb33dae791e5f59f1d0d27c0221db3b3b4c16d Mon Sep 17 00:00:00 2001 From: Paul Eggert <egg...@cs.ucla.edu> Date: Thu, 15 Feb 2024 18:45:29 -0800 Subject: [PATCH] =?UTF-8?q?Adjust=20to=20yesterday=E2=80=99s=20Gnulib=20ns?= =?UTF-8?q?trftime=20changes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bruno Haible fixed Gnulib so that nstrftime no longer requires locking code, which means we no longer need to avoid localename. However, nstrftime now requires localename-unsafe-limited which pulls in some Gnulib-specific locale code, and it’s likely this needs to be replaced with Emacs-specific locale code. In the meantime let’s continue to finess this by avoiding localename-unsafe-limited. * admin/merge-gnulib (AVOIDED_MODULES): Avoid localename-unsafe-limited instead of localename. --- admin/merge-gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/merge-gnulib b/admin/merge-gnulib index 35966852e27..41531d573b0 100755 --- a/admin/merge-gnulib +++ b/admin/merge-gnulib @@ -53,7 +53,7 @@ GNULIB_MODULES= AVOIDED_MODULES=' access btowc chmod close crypto/af_alg dup fchdir fstat - iswblank iswctype iswdigit iswxdigit langinfo localename lock + iswblank iswctype iswdigit iswxdigit langinfo localename-unsafe-limited lock mbrtowc mbsinit memchr mkdir msvc-inval msvc-nothrow nl_langinfo openat-die opendir pthread-h raise save-cwd select setenv sigprocmask stat stdarg -- 2.40.1
