Sam Russell <sam.h.russ...@gmail.com> writes:

> Thanks for merging Simon.
>
> I've fixed a couple of issues with building gzip, marking the functions as
> static fixes the -Werror=missing-declarations error, and
> the MAINTAINERCLEANFILES variable isn't set when building gzip so there's
> an error when using += with it.

I think you should add 'MAINTAINERCLEANFILES =' to gzip instead.
Otherwise I suspect 'make distcheck' will not work (please test that in
gzip after final changes).

> There's another issue with the way fopen/fprintf work and I can't
> figure out how to fix it:

Sounds like you need to link crc-generate-table with the gnulib
replacement library.  I don't know how gzip is setup to do this, maybe
it is has to be fixed there, or the 'crc-tests' module has to add some
more dependencies.

/Simon

Attachment: signature.asc
Description: PGP signature

Reply via email to