Bruno Haible via Gnulib discussion list <bug-gnulib@gnu.org> writes:
>> Proposed patch is attached.
>
> I guess you want the patch to be reviewed?
>
> Reviewing a patch, for me, includes validating that the body of a
> function implements its specification comment. But all three new
> functions lacks such a comment; therefore I can't really review anything.
I was going to take a look as well. Agree that comments would be nice
though. Since I (and likely others) do not fully understand linux-isms
like sysfs, procfs, and cgroups.
> I see four lines that need whitespace fixes:
> return strdup ("/sys/fs/cgroup");
> snprintf(cpu_max_file, sizeof (cpu_max_file),
> #if HAVE_MNTENT_H
> #endif
Some other spacing nits, they all need a space before parentheses:
endmntent(fp);
switch (sched_getscheduler(0))
quota = get_cgroup2_cpu_quota();
Collin
