Pádraig Brady <[email protected]> writes:

> This looks to be a from scratch implementation,
> rather than being based on any reference implementations right?

Yep. Some parts are taken from the other crypto modules, e.g.
lib/sha512.{h,c} and modified where needed.

> It would be good to verify that we don't have the following bug
> from the reference implementations:
> https://mouha.be/sha-3-buffer-overflow/

Ah, so there is a well-maintained Keccak package. Not sure how I did not
see that earlier.

I'll have a look at adding that test case.

Collin

Reply via email to