Bruno Haible <[email protected]> writes:

> 0001:
>>               ])
>>             ;;
>>         esac
>> -      ])
>> +       rm -f conftest.data conftest.empty])
>>      case "$gl_cv_func_working_getdelim" in
>>        *yes) ;;
>>        *) REPLACE_GETDELIM=1 ;;
>
> Please can you add a line break between the 'rm -f' command
> and the closing bracket from the AC_something invocation?
> One should be able to understand the nesting of blocks
> by looking up and down vertically, without looking at the
> far right of each line. Especially for a block that is more
> than 10 lines long. Thanks.

Of course!

It is very difficult to indent Autoconf and m4 properly in my opinion
since Emacs cannot really highlight matching parentheses/brackets
correctly. I assume this is because C/Shell snippets inside of macros
can have ')' or ']' which will be interpreted as matching the previous
opening '(' or ']'.

Maybe there is a trick that I am missing to keep track of indentation?
Or just lack of experience writing Autoconf and m4?

Collin

Reply via email to