Hi Collin, > I wonder if it is worth adding the checks for __has_feature, > __has_include, etc. in m4/gnulib-common.m4 so that we don't need to > repeat the #ifdef's around everywhere, we can just assume it is defined > in config.h. Any reason to avoid that?
gnulib-common.m4 is used by all packages, and users have no simple way of customizing/overriding what it does. Therefore it is risky to play with compiler built-ins like __has_feature there. If you want to minimize the duplication of the test if ASAN is enabled, tests/macros.h is a better place, I would say. At least until we have a really good reason to move it to gnulib-common.m4. Bruno
