"Basil L. Contovounesios" <[email protected]> writes:

> SGTM, thanks.  Updated patches attached.

Thank you!

>  # An ERE quoted for the shell, for matching a version+date line prefix.
> -news-check-regexp ?= '^\*.* $(VERSION_REGEXP) \($(today)\)'
> +news-check-regexp ?= '^[\#*].* $(VERSION_REGEXP) \($(today)\)'
>  
>  # Like news-check-regexp, but as an unquoted BRE for .prev-version.
> -news-check-regexp-prev ?= ^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)
> +news-check-regexp-prev ?= ^[\#*].* $(PREV_VERSION_REGEXP) ([0-9-]*)
...
>  # Keep consistent with news-check-regexp and news-check-regexp-prev.
> -gl_noteworthy_news_ ?= * Noteworthy changes in release ?.? (????-??-??) [?]
> +gl_noteworthy_news_ ?= \
> +  $(if $(filter %.md,$(NEWS_file)),#,*) \
> +  Noteworthy changes in release ?.? (????-??-??) [?]

Per the last comment, these are now no longer in sync -- but you don't
need filter here, do you?  Doesn't it work to use a catch-all regexp
here too?

Otherwise okay!

/Simon

Attachment: signature.asc
Description: PGP signature

Reply via email to