Hi Collin, > How about this patch? It mostly reverts my earlier changes.
This looks all good. > However, I kept the ./configure test changes that moved to this idiom: > > int result = 0; > if (/* Some check that fails. */) > result |= 2; > if (/* Some other check that fails. */) > result |= 4; > > Since I find it very helpful when trying to understand a function is > replaced and what issues a platform has. Of course, yes, this idiom is useful and can be kept. > > So, getdelim.m4 should be changed so that all three implementations are > > accepted: > > - the one from glibc 2.42, musl, OpenBSD, AIX, > > - the one from macOS, FreeBSD, Solaris, > > - the one from glibc 2.43, > > and none of these system functions gets overridden. > > I tested this patch on glibc 2.42 and glibc 2.43 the function does not > get replaced. > > I also tested it on FreeBSD 15.0, Solaris 11.4, and OpenBSD 7.8 and > confirm they do not get replaced there too. Perfect! Thanks. Bruno
