Hi,

>  11/14/2022     # Common U.S. writing.
> +14.11.2022     # Common European writing.

That's a good and major improvement.

> @@ -1469,6 +1491,12 @@ yylex (union YYSTYPE *lvalp, parser_control *pc)
>                for (digits = 2; digits <= LOG10_BILLION; digits++)
>                  {
>                    ns *= 10;
> +                  /* Don't parse DD.MM.YYYY dates as a decimal  */
> +                  if (*p == '.') {
> +                    p = old_p;
> +                    pc->not_decimal = true;
> +                    goto normal_value;
> +                  }
>                    if (c_isdigit (*p))
>                      ns += *p++ - '0';
>                  }

Can we have this 'if' statement reformatted in GNU coding style?

Also, how about adding two test cases in the unit test
tests/test-parse-datetime.c, around line 238 ?
I guess that some test case was already added to coreutils, but since
parse-datetime is a Gnulib module, its essential functionalities should
be covered by the Gnulib unit test.

Bruno




Reply via email to