Paul Eggert wrote:
> The ‘BLOCKSIZE + 72’ business apparently dates back to 30 years
> ago when the buffer was local (not heap allocated) and was multi-use.
> That code died long ago

Are you sure? For 30 minutes, I'm trying to determine at which commit
the use of these extra bytes was removed from
   lib/md5.c
   lib/md5-stream.c
and I can't find it.

The line in lib/md5.c, function md5_finish_ctx,

  memcpy (&((char *) ctx->buffer)[bytes], fillbuf, (size - 2) * 4 - bytes);

still looks like it needs at least 64 bytes beyond BLOCKSIZE. No?

Bruno




Reply via email to