Hi, Alyssa Ross wrote: > diff --git a/m4/free.m4 b/m4/free.m4 > index c7a134bab8..81a8ccd9b9 100644 > --- a/m4/free.m4 > +++ b/m4/free.m4 > @@ -20,25 +20,31 @@ AC_DEFUN([gl_FUNC_FREE], > dnl <https://sourceware.org/PR17924> > dnl * OpenBSD >= 4.5, thanks to this commit: > dnl > <https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/stdlib/malloc.c.diff?r1=1.100&r2=1.101&f=h> > + dnl * musl >= 1.2.3, thanks to these commits: > + dnl > <https://git.musl-libc.org/cgit/musl/commit/?id=9b77aaca86b53c367f23505c24dd3c02e240efad> > + dnl > <https://git.musl-libc.org/cgit/musl/commit/?id=2010df0d64570db4ce29cc7df0e31f81aa26ae4a> > dnl * Solaris, because its malloc() implementation is based on brk(), > dnl not mmap(); hence its free() implementation makes no system calls.
Thanks for the proposed patch. But the change that you point to was only in 2021. Hence gl_cv_func_free_preserves_errno should be set to 'yes' for newer versions of musl, and to 'no' for older ones. But your patch sets it to 'yes' always. If the change was long ago, for instance in 2012, I would agree. But 2021 is not that old... Bruno
