> Date: Sat, 10 Oct 2026 14:41:58 -0700 > Cc: [email protected], Gnulib bugs <[email protected]>, > Emacs Development <[email protected]>, Yue Yi <[email protected]> > From: Paul Eggert <[email protected]> > > On 2026-10-10 00:44, Eli Zaretskii wrote: > > Paul, any suggestions given the above? > > This patch adds two Gnulib modules localtime and tzsanitize to Emacs, and > emacs/admin/merge-gnulib said I should fix nt/gnulib-cfg.mk or notify > emacs-devel. I'm doing the latter in this email's cc. Though I'm no NT expert > I guess no change to nt/gnulib-cfg.mk is needed.
Actually, this broke the MS-Windows build, because Emacs on MS-Windows has its own replacement for localtime in w32.c. When fixing this, I realized that omitting the localtime module via nt/gnulib-cfg.mk is not enough, because Gnulib's time.h forcibly redirects localtime to rpl_localtime on MS-Windows. I fixed that by a kludge: I added a trivial rpl_localtime to both lib-src programs and to Emacs itself, but I hope the Gnulib folks will add something to Gnulib to allow omitting the localtime module in a cleaner fashion. Btw, why does tzsanitize call SetEnvironmentVariable only in the UCRT build, leaving the MSVCRT build with an invalid TZ=$ setting? The comments in the code don't explain this part of the implementation, or what did I miss?
