Hi Bruno, Yes, it's a typo since "0" is a valid file descriptor. Thanks for pointing out.
Ondrej Zasláno z Outlooku pro Android<https://aka.ms/AAb9ysg> ________________________________ From: Bruno Haible <[email protected]> Sent: Sunday, 25 October 2026 00:53:21 To: Ondrej Valousek <[email protected]> Cc: [email protected] <[email protected]>; Eric Cai <[email protected]> Subject: Fwd: [PATCH] qcopy-acl: accept file descriptor zero Hi Ondrej, This looks like a typo in your patch from 2023-01-04 https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.gnu.org%2Farchive%2Fhtml%2Fbug-gnulib%2F2023-01%2Fmsg00020.html&data=05%7C02%7Condrej.valousek.xm%40renesas.com%7C8c3c1377695548072b4b08df3221a196%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C639284792184672484%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=qRpvxD742ANvFMIQPTXbyzwNN0qQxfbgbpSmFoNa71o%3D&reserved=0<https://lists.gnu.org/archive/html/bug-gnulib/2023-01/msg00020.html> Do you agree? Bruno ---------- Forwarded Message ---------- diff --git a/lib/qcopy-acl.c b/lib/qcopy-acl.c --- a/lib/qcopy-acl.c +++ b/lib/qcopy-acl.c @@ -89,7 +89,7 @@ qcopy_acl (const char *src_name, int source_desc, const char *dst_name, to copy */ if (ret == 0) { - ret = source_desc <= 0 || dest_desc <= 0 + ret = source_desc < 0 || dest_desc < 0 ? attr_copy_file (src_name, dst_name, is_attr_permissions, NULL) : attr_copy_fd (src_name, source_desc, dst_name, dest_desc, is_attr_permissions, NULL); -----------------------------------------
