On 5/7/09 10:09 AM, H. Langos wrote:
Did you check when (at which version) MP3::Info gained APE support?
I did just now and APE support was added in MP3::Info v1.20, Saturday, January 7, 2006
It would be good to check for this in configure.ac as it already is done for utf8 support.
Configure.ac is now checking for v1.01 from 2002. I guess we can just change the UTF8 warning into an APE warning and check for v1.20?
Also making sure that older versions don't choke on those extra parameters would be good. (A short look at the code should be enough.)
I checked and version 1.13 (10 March 2005) should not have any issues with the additional parameters passed to get_mp3tag().
Are you sure there is always at least one whitespace between the numbers and the "dB" string? When reading the replaygain related web pages I see that most people tend to write stuff like "-12dB" or "6dB". I wouldn't be surprised if some programers followed that example. Or is there some standard definition for this?
I was actually thinking the same thing. The space is the way mp3gain does it, but it is not very common to use a space, no. Since mp3gain is the de facto software to use for calculating ReplayGain it doesn't really matter though. We can change the \s+ to \s* for completeness sake. The \s+ was in the code I borrowed, and I just didn't touch it.
BTW: While you're at it ... have you ever seen RVA / RVA2 / XRVA tags in the wild?
I tag 99% of my own files, but I did see RVA2 tags on some iTunes mangled files, yes. Note that iTunes uses iTunNORM for Sound Check and RVA2 for that volume slider thingie. I read a post of someone who volume leveled his whole collection using that slider.. yikes. I so prefer mp3gain. :-)
Richard _______________________________________________ Bug-gnupod mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/bug-gnupod
