Re: NSUser.m: Bug on Windows handling spaces in environement variable values?

[Kazunobu Kuriyama]

David Ayers wrote:

Adam Fedor wrote:

Any comments on this patch?

Incidently, make/user_home.c seems to have a bug:

diff -u -r1.13 user_home.c
--- user_home.c 30 Nov 2003 10:18:46 -0000      1.13
+++ user_home.c 18 Feb 2004 16:43:11 -0000
@@ -204,9 +204,9 @@
 
       for (i = 0; i < strlen(home); i++)
        {
-         if (isspace((int)home[0]))
+         if (isspace((int)home[i])) 

Though I'm not sure whether there's an 8-bit char making isspace() 
nonzero after
its type is promoted to signed int, the cast (int) should be replaced with
(unsigned int) to avoid an inadvertent sign extension.

Cheers,
- Kazunobu Kuriyama


_______________________________________________
Bug-gnustep mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-gnustep