Follow-up Comment #1, patch #4575 (project gnustep):
These are minor quibbles ...
1. You create a global variable '__gui_theme', but provide setter/getter
methods +setTheme: and -getTheme:
Now ... if it's really intended to be a global variable, I think it should
follow standard naming conventions and be called something like GSGUITheme
(but then the set/get matchods aren't needed).
If it's not intended to be global, it should be declared static ... but it
should perhaps have a more conventional name
eg 'theTheme'.
2. You define a macro in the public header ... THEME to return the object ...
but again we should have a name like GSTHEME to avoid possible conflicts with
user code.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=4575>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
Bug-gnustep mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-gnustep
