On 09/11/19 21:47, Johannes Marbach wrote: > Hi Mark, > > Johannes Marbach wrote: >> One thing I noticed when downloading other extensions from >> addons.mozilla.org is that they have a cose.manifest and a cose.sig file >> in the META-INF folder. These seem to not be present in the extensions >> bundled with IceCat. I'm not sure how the copies that are bundled with >> the IceCat source were acquired but maybe they have to be redownloaded >> from Mozilla to get the latest signature variant? > > Picking up on my own quote here, I noticed that these "cose" files are > deleted in the script that fetches the extensions > (https://git.savannah.gnu.org/cgit/gnuzilla.git/tree/data/update-extensions.sh?h=68#n33): > > find extensions -name cose.manifest -delete > find extensions -name cose.sig -delete > > There's probably been a good reason for this at some point but given > that there are signature issues in the 68 preview, maybe this could be > related?
'cose.manifest' are files unrecognized yet. From recent IceCat-68.2.0 build: Error: /builddir/build/BUILD/icecat-68.2.0/objdir/dist/bin/browser/extensions/[email protected]/META-INF/cose.manifest:643: Unknown manifest directive: Name: Error: /builddir/build/BUILD/icecat-68.2.0/objdir/dist/bin/browser/extensions/[email protected]/META-INF/cose.manifest:644: Unknown manifest directive: Digest-Algorithms: Error: /builddir/build/BUILD/icecat-68.2.0/objdir/dist/bin/browser/extensions/[email protected]/META-INF/cose.manifest:645: Unknown manifest directive: SHA1-Digest: Error: /builddir/build/BUILD/icecat-68.2.0/objdir/dist/bin/browser/extensions/[email protected]/META-INF/cose.manifest:646: Unknown manifest directive: SHA256-Digest: Traceback (most recent call last): > > Looking at that script some more, I also noticed that it already has > fallbacks for extensions that don't define an explicit ID in their > manifest. However, these fallback IDs are only used for the directory > and file name: > > if [ -f /tmp/update-extension/manifest.json ]; then > ID=$(grep '"id":' /tmp/update-extension/manifest.json |head > -n1|cut -d \" -f 4) > fi > > [ $extension = "tortm-browser-button" ] && > ID="tortm-browser-button@jeremybenthum" > [ $extension = "use-google-drive-with-librejs" ] && > ID="[email protected]" > [ -z $ID ] && ID=$extension"@extension" > > rm -rf extensions/$ID > mv /tmp/update-extension extensions/$ID > > I wonder if maybe we could add these to the manifest as well to try and > fix the issue of ID-less extensions (such as > tortm-browser-button@jeremybenthum) not showing up in IceCat? > > Best, > Johannes > -- --- Antonio Trande Fedora Project mailto 'sagitter at fedoraproject dot org' GPG key: 0x7B30EE04E576AA84 GPG key server: https://keys.openpgp.org/
signature.asc
Description: OpenPGP digital signature
