Hi Paolo, > > diff1: > > I seem that It should match at the head of the line when start_ptr > > isn't set. > > Do you have a testcase? I'm hesitant to apply this without one.
No. Though I had the test case for this patch, I have lost it... A little time is necessary to make it. > > diff2: > > We don't have to convert text to lower-case in MB_CUR_MAX> 1. > > Ok, I made a matching change to the XXX comment. Graceful. > However, maybe we have > to provide instead a !MBS_SUPPORT version of mbtolower, and use it > unconditionally? Hmm, We mayn't also need to convert a text into the lower case for MB_CUR_MAX == 1, but I don't make sure that. > diff5 is ok too, but I made some changes there. > > Would you mind reviewing the patches I posted to the mailing list? Ok. But I don't like cur_mb_len not to be modified with `const', though it's always equal to 1 in !MBS_SUPPORT. Regards,
