On 03/24/2010 11:29 AM, Jim Meyering wrote: > Paolo Bonzini wrote: >> On 03/24/2010 11:12 AM, Jim Meyering wrote: >>> I want to release grep-2.6.1 today, with only the bug fix >>> and test addition/tweak, and omitting my pkg-config-excising change >>> (slight portability risky). Unless someone manages to report another >>> failure in the next 2-3 hours... >>> >>> Any objection? >> >> Let's see what happens with Norihirio's patches? But I would have no >> problem with releasing before they go in. > > They seem worth including, especially if we can construct a test or two. > It now seems prudent to defer the release until tomorrow.
I've finally tried building on cygwin 1.5; --enable-gcc-warnings exposes: savedir.c:43: warning: declaration of 'path' shadows a global declaration in gnulib, and this in main.c: main.c:1628: warning: passing arg 2 of `rpl_getopt_long' discards qualifiers from pointer target type but ignoring errors, the build completes, so I don't see those as show-stoppers. Also, the generation of [ef]grep.1 is noisy, even with 'make V=0', although that's cosmetic. Cygwin 1.5 actually passes more tests than cygwin 1.7 (namely, the gnulib tests for btowc), but that still says that the bug is in cygwin 1.7, not in grep (and maybe that gnulib should work around it in the meantime, but such a workaround would only affect cygwin, where I already have some influence on the grep port). -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
