Paolo Bonzini wrote:
> * tests/Makefile.am (check_PROGRAMS): Add get-mb-cur-max.
> * tests/get-mb-cur-max.c: New.
> * tests/euc-mb: Use it. Fail if the former detection test fails.
> * tests/sjis-mb: Use it. Fail if the former detection test fails.
> ---
> tests/Makefile.am | 3 +++
> tests/euc-mb | 25 +++++++++++++++++--------
> tests/get-mb-cur-max.c | 36 ++++++++++++++++++++++++++++++++++++
> tests/sjis-mb | 15 +++++++++------
> 4 files changed, 65 insertions(+), 14 deletions(-)
> create mode 100644 tests/get-mb-cur-max.c
...
> -make_input BABAAB |euc_grep AB || \
> - fail_ 'whole line rejected after matching in the middle of a multibyte
> char'
> +case `get-mb-cur-max $locale` in
> + 2|3) ;;
> + *) skip_ 'EUC-JP locale not found' ;;
> +esac
Good. That one applies.
I see you also addressed the "make syntax-check" failures. Thanks.
I looked at the uses of get-mb-cur-max and noticed a small inconsistency:
$ git grep get-mb-cur
tests/Makefile.am:check_PROGRAMS = get-mb-cur-max
tests/euc-mb:case `get-mb-cur-max $locale` in
tests/sjis-mb:test "$(get-mb-cur-max $locale)" = 2 || skip_ 'SJIS locale
not found'
I will add a syntax-check rule to automatically enforce the
"we-prefer-$(...)-over-`...`" policy. There are few violations,
and the naive regexp gets few FP matches (exempting those in init.sh,
which are required).
Please push that.
Do you have any other pending patches?
