On 03/31/2010 08:48 AM, Jim Meyering wrote: > Thanks, but I have to refuse such changes, especially in the likes > of dfa.c. They decrease readability. It is already too complex, > and as soon as grep stabilizes (i.e. goes a week or so without a new bug > report) I plan to move many more declarations "down", along with other > clean-up and maintainability- and readability-improving changes.
Jim, your statements hold true for coreutils and grep directly. But I recall that gnulib still aims for C89 compilation out-of-the-box, and isn't the intent to move dfa.c into gnulib, at which point, a patch like this would be important? -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
