On 04/07/2010 08:49 PM, Aharon Robbins wrote:
Attached is a patch formatted per the HACKING file's instructions. It's
my*very first*  use of git, so be kind.

Not bad at all, just format the commit message like this: one-line summary ("move dfa internals into dfa.c"), blank line, changelog.

This avoids that the patch is formatted like this:

Subject: [PATCH] dfa.h: Moved essentially all the dfa internals out of dfa.h. New routines added as needed. dfa.c: The dfa internals are now totally local to this file. A few new routines added for access to features.
 dfasearch.c: Modified for changes in interface.

Paolo


Reply via email to