On 11/14/2010 05:11 PM, Jim Meyering wrote:
Paolo Bonzini wrote:
* src/system.h: Add multiple inclusion guards.
* src/grep.h: Likewise.
...
diff --git a/src/grep.h b/src/grep.h
+#ifndef GREP_GREP_H
+#define GREP_GREP_H 1
...
+#endif
...
diff --git a/src/system.h b/src/system.h
...

Those look fine.  Thanks.
You're adding them just on principle?

Just in principle, I have some patches that actually failed to compile without guards but I'm not submitting them.

Paolo

Reply via email to