Eric Blake wrote: > On 06/17/2011 06:45 AM, Jim Meyering wrote: >> I'm prepared to release grep-2.9. >> There have been more than enough fixes since 2.8: >> (from NEWS): > > In the tests directory, some but not all of the tests are marked > executable. For example, when I did a git pull, I noticed: > > create mode 100644 tests/bogus-wctob > create mode 100755 tests/dfa-heap-overrun > create mode 100644 tests/equiv-classes > create mode 100644 tests/high-bit-range > create mode 100644 tests/inconsistent-range > create mode 100755 tests/pcre-abort > create mode 100755 tests/turkish-I > create mode 100644 tests/unibyte-bracket-expr > > Should all of the tests be 755 rather than 644?
Thanks for looking. I suppose I should make them consistent, but it really doesn't matter, since each is invoked via "$(SHELL) test_name". Back when scripts were invoked via ./test_name it used to matter. There's a "make check" test (vc_exe_in_TESTS) in coreutils that ensures all VC'd test scripts are executable, but it's not cheap, so I've been toying with the idea of removing it.
