Hi Jim.
On Thursday 15 September 2011, Jim Meyering wrote:
> From: Jim Meyering <[email protected]>
>
> * src/searchutils.c (kwsinit): Remove in-function #if MBS_SUPPORT.
> ---
> src/searchutils.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/src/searchutils.c b/src/searchutils.c
> index 9dac023..e6a5cbb 100644
> --- a/src/searchutils.c
> +++ b/src/searchutils.c
> @@ -28,11 +28,7 @@ kwsinit (kwset_t *kwset)
> static char trans[NCHAR];
> int i;
>
> - if (match_icase
> -#if MBS_SUPPORT
> - && MB_CUR_MAX == 1
> -#endif
> - )
> + if (match_icase && MBS_SUPPORT && MB_CUR_MAX == 1)
>
Maybe I'm missing something fundamental, but this looks defintely wrong
to me. The code guarded by this "if" will now never be run when
MBS_SUPPORT is 0, while previously is was run if `match_icase' was 1
and MBS_SUPPORT was 0. Maybe you intended to use like this instead?
if (match_icase && (!MBS_SUPPORT || MB_CUR_MAX == 1)) { ... }
Regards,
Stefano
