On 09/15/2011 02:21 PM, Jim Meyering wrote:
> As an additional cleanup, you can make using_utf8() return always
> false if !MBS_SUPPORT.
using_utf8 does that already:
static inline int
using_utf8 (void)
{
static int utf8 = -1;
if (utf8 == -1)
{
#if defined HAVE_LANGINFO_CODESET&& defined MBS_SUPPORT
utf8 = (STREQ (nl_langinfo (CODESET), "UTF-8"));
#else
utf8 = 0;
#endif
}
return utf8;
}
Then I missed the conversion to if() in you patch series, or equivalently to
static int utf8 = MBS_SUPPORT ? -1 : 0;
> This lets you clean up dfa_optimize further.
This still stands. :)
Paolo
