On 09/16/2011 01:01 PM, Jim Meyering wrote:
+
+#if ! MBS_SUPPORT
+# undef MB_CUR_MAX
+# define MB_CUR_MAX 1
+#endif
Thanks for splitting the tail of the series. I'm still a bit nervous
about redefining a libc macro.
What about changing this patch to a sweeping s/MB_CUR_MAX/GREP_MB_MAX/g
and doing
#define GREP_MB_MAX (MBS_SUPPORT ? MB_CUR_MAX : 1)
instead?
It should be easy to do a global search-and-replace on the patch files
so that they apply on top of a tree that uses GREP_MB_MAX.
Also, I am not sure why patch 2/5 is there if it fixes a compilation
failure, and not at the beginning to prevent the failure?
Paolo
