Paul Eggert wrote: > On 12/29/11 13:56, Paolo Bonzini wrote: >> there is no reason to split files > > Yes there is: separation of concerns. > The Microsoft stuff is a separate porting layer, > like gnulib, and like gnulib it shouldn't > be in the same source directory as the main code. > > For example, I commonly use 'grep' to scan code, > and I'd rather not have to plow through the > Microsoft-specific stuff when I do something like > "grep size_t *.[ch]".
That change adds many lines of easily-abstracted code that is useful only to Windows systems. Their mere presence in a file like main.c make it less readable/maintainable. I too think it belongs in a separate file in a separate directory. Besides, in-source #ifdefs (and platform-ifdefs at that) are best avoided.
