Hi Jim et al. > It's a little annoying that STREQ is already defined in two places > (we prefer to keep dfa.c self-contained, to accommodate gawk): > > $ git grep fine.STREQ > src/dfa.c:#define STREQ(a, b) (strcmp (a, b) == 0) > src/main.c:#define STREQ(a, b) (strcmp (a, b) == 0) > > You may want to simply exempt those two files from that check.
There are not a lot of uses of STREQ in dfa.c. I'd be happy if you expanded the macro there. Gawk's STREQ checks *a == *b before calling strcmp, which is an OOOOLLLLDDDD speed hack from the PDP-11 / Vax days. I should probably get rid of it. Thanks, Arnold
