On 03/18/2012 11:34 AM, Jim Meyering wrote: > it would be good to add a test > that requires each of the two new DFA-emitted diagnostics.
Yes, and more generally, the BRE and ERE tests could check for spelling of diagnostics, and grep could use the same spellings in both the regex and the dfa cases. This could be done in two more patches, I suppose. Things could get a little tricky there, though, as the spellings might differ depending on whether grep is built --with-included-regex. Possibly dfa.c should not use its own diagnostic strings at all, and just use regex's. But this is turning into a bigger project.... Anyway, for now I pushed the fix, with your cfg.mk patch added.
